hook up start and shutdown functions in fileexporter #3260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sincejune
changed the title
sincejune
changed the title
carlosalberto
approved these changes
May 24, 2021
bogdandrutu
requested changes
May 24, 2021
bogdandrutu
approved these changes
May 24, 2021
bogdandrutu
reviewed
May 24, 2021
Contributor
|
@sincejune Thanks for the fix. @bogdandrutu We won't be using the v0.27.0 release, so as long as this is fixed going forward, this issue can be closed. |
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
…3260) * hook up start and shutdown functions in fileexporter * fix tests * Revert "fix tests" This reverts commit f296b10. * check file closed * Revert changes in exporter.go * Update factory.go Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hook up
StartandShutdownfunctions in fileexporter to avoid nil file handler.Testing:
Manually tested.